16 Jul
2019
16 Jul
'19
8:01 a.m.
Sathya Prakash M R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33932 )
Change subject: mb/google/helios: Add ALC1011 in device tree to enable speaker amps ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33932/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/gpio.c:
https://review.coreboot.org/c/coreboot/+/33932/2/src/mainboard/google/hatch/... PS2, Line 91: PAD_NC
Wait. […]
I will try this. But 1 change Aamir suggested on Patch set#1 and that didnt work. let me try this and get back.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33932
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d71e3bd2d4493d059a33023c1afe1b630181d4f
Gerrit-Change-Number: 33932
Gerrit-PatchSet: 2
Gerrit-Owner: Sathya Prakash M R sathya.prakash.m.r@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Naveen M naveen.m@intel.com
Gerrit-Reviewer: Sathya Prakash M R sathya.prakash.m.r@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jul 2019 06:01:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sathya Prakash M R sathya.prakash.m.r@intel.com
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment