Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35920 )
Change subject: helios: Add TEMP_SENSOR4 to DPTF
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35920/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/35920/1/src/mainboard/google/hatch/...
PS1, Line 57: #define DPTF_TSR3_SENSOR_ID 3
: #define DPTF_TSR3_SENSOR_NAME "CPU"
: #define DPTF_TSR3_PASSIVE 85
: #define DPTF_TSR3_CRITICAL 100
: #define DPTF_TSR3_ACTIVE_AC0 0
: #define DPTF_TSR3_ACTIVE_AC1 0
: #define DPTF_TSR3_ACTIVE_AC2 0
: #define DPTF_TSR3_ACTIVE_AC3 0
: #define DPTF_TSR3_ACTIVE_AC4 0
: #define DPTF_TSR3_ACTIVE_AC5 0
:
Where did all the setpoints/thresholds come from?
https://b.corp.google.com/issues/142266102#comment7
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35920
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bc19f9b9bd644e134987749ad9a4d875ad8b40a
Gerrit-Change-Number: 35920
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@chromium.org
Gerrit-Reviewer: Scott Collyer
scollyer@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Fagerburg
pfagerburg@google.com
Gerrit-Comment-Date: Wed, 09 Oct 2019 22:50:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment