8 Feb
2020
8 Feb
'20
11:37 a.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37895 )
Change subject: arch/x86: Top align bootblock program ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37895/4/src/cpu/x86/16bit/reset16.l... File src/cpu/x86/16bit/reset16.ld:
https://review.coreboot.org/c/coreboot/+/37895/4/src/cpu/x86/16bit/reset16.l... PS4, Line 46: 0xf0
Why the 256 (0xf0 + 16) total offset subtracted from the calculation? I'm not following all the math […]
It's the reserve for fit.S and id.S AFAIR. Like discussed, those should have proper subsections instead.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37895
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If32518b1c19d08935727330314904b52a246af3c
Gerrit-Change-Number: 37895
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-CC: David Hendricks david.hendricks@gmail.com
Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-CC: Werner Zeh werner.zeh@siemens.com
Gerrit-Comment-Date: Sat, 08 Feb 2020 10:37:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Gerrit-MessageType: comment