Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32381 )
Change subject: soc/intel/braswell: add default option to use public FSP ......................................................................
Patch Set 2:
(1 comment)
This patch seems to be similar as https://review.coreboot.org/c/coreboot/+/29661 Would rebase the differences on that patch an alternative?
yes, I did base my patch on yours - was trying to see if a cleaner approach to which header to use could be found. I have no preference on whose patch is used, just that the issue is resolved as cleanly as possible.
https://review.coreboot.org/#/c/32381/2/src/soc/intel/braswell/Makefile.inc File src/soc/intel/braswell/Makefile.inc:
https://review.coreboot.org/#/c/32381/2/src/soc/intel/braswell/Makefile.inc@... PS2, Line 59: CPPFLAGS_common += -I$(call strip_quotes,$(CONFIG_FSP_HEADER_PATH))
Did you also build and test after you removed the FspUpdVpd.h binary in vendorcode/../braswell? […]
I just did a test build with the header in vendorcode deleted, and no issues building. I don't see how it would still be used since that path is no longer included. Searching the ./build directory confirms this