4 Jun
2019
4 Jun
'19
5:21 p.m.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33115 )
Change subject: Makefile.inc: Compile smm files independent ARCH_RAMSTAGE_X86_32/64 ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/33115/7/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/#/c/33115/7/src/arch/x86/Makefile.inc@340 PS7, Line 340: smm-$(CONFIG_IDT_IN_EVERY_STAGE) += idt.S
Why weren't the above moved?
i was only keeping root dependencies for now. looks like !ramstage build is not bothered about those files.
Also i don't think payload loads from postcar might not required these.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33115
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17a3eb80a4d5ef86e0319357c01b6bf5b90ef15b
Gerrit-Change-Number: 33115
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:21:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Gerrit-MessageType: comment