Attention is currently required from: Bao Zheng, Fred Reitberger, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81252?usp=email )
Change subject: amdfwtool: Add functions to link all the tables
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
would be good to mention in the commit message that integrate_psp_levels and integrate_bios_levels now only get called in the case where a level 2 directory table needs to be integrated into a level 1 directory table. at least that would have made it easier for me to see why only calling this in some cases is correct
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81252?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieaf97208e943c79d7b76ea62eea9355138c220b9
Gerrit-Change-Number: 81252
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Mon, 18 Mar 2024 23:01:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment