Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38424 )
Change subject: cbfs: Enable CBFS mcache on most boards
......................................................................
Patch Set 5:
It should be no problem to increase CAR space on the x86 boards in here.
You mean instead of disabling it on those northbridges? You may be right but I don't have any experience with those platforms and what to look out for when changing the CAR size (and no boards to test), so I think I'd rather check this patch in as is for now and if there's desire to use this feature on some of those boards later, it should be easy to enable for someone who is familiar with them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38424
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0abd1c813aece6e78fb883f292ce6c9319545c44
Gerrit-Change-Number: 38424
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jan 2020 20:08:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment