Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38844 )
Change subject: mainboard/hatch: Change SKU_MAX to 0x7FFFFFFF ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38844/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38844/1//COMMIT_MSG@7 PS1, Line 7: mainboard/hatch: Change SKU_MAX to 0x7FFFFFFF mainboard/hatch/mainboard.c: Accommodate larger SKU id space
https://review.coreboot.org/c/coreboot/+/38844/1//COMMIT_MSG@9 PS1, Line 9: Default This doesn't add anything that the code doesn't already say. I think you want to say something like:
``` Allow INT32_MAX sku id encodings beyond UINT8_MAX. This allows for the sku id to accommodate up to 4 bytes however we reserve the highest bit for SKU_UNKNOWN to be encoded. ```