[coreboot-gerrit] Change in coreboot[master]: {drivers,soc}/intel/fsp1_1: Move chipset specific logo handling to SoC

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37791 )

Change subject: {drivers,soc}/intel/fsp1_1: Move chipset specific logo handling to SoC
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37791/4/src/drivers/intel/fsp1_1/lo... 
File src/drivers/intel/fsp1_1/logo.c:

https://review.coreboot.org/c/coreboot/+/37791/4/src/drivers/intel/fsp1_1/lo... 
PS4, Line 29: 			if (logo_size)
Should this be `*logo_size`? A null-pointer check after dereference seems odd.

https://review.coreboot.org/c/coreboot/+/37791/4/src/drivers/intel/fsp1_1/ra... 
File src/drivers/intel/fsp1_1/ramstage.c:

https://review.coreboot.org/c/coreboot/+/37791/4/src/drivers/intel/fsp1_1/ra... 
PS4, Line 217: }
I doubt this will ever be used.