[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer/var/halvor: Update dq/dqs mappings

[Amanda Hwang (Code Review)]

Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43988 )

Change subject: mb/google/volteer/var/halvor: Update dq/dqs mappings
......................................................................

Patch Set 6:

(4 comments)

Would you help to review the CL again?
Thank you.

https://review.coreboot.org/c/coreboot/+/43988/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43988/4//COMMIT_MSG@7 
PS4, Line 7: Update dq/dqs mappings
> mb/google/volteer/var/halvor: Update dq/dqs mappings

Done

https://review.coreboot.org/c/coreboot/+/43988/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43988/5//COMMIT_MSG@11 
PS5, Line 11: 162042254
> The bug should accurately reflect what's going on. […]

I have updated bug:162892573 and uploaded reference document for DQ/DQS mappings in Halvor.

https://review.coreboot.org/c/coreboot/+/43988/2/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/memory.c:

https://review.coreboot.org/c/coreboot/+/43988/2/src/mainboard/google/voltee... 
PS2, Line 10: 			{  3,  0,  1,  5,  4,  7,  6,  2 }, /* DDR0_DQ1[7:0] */
> nit: align all the comments

Done.

https://review.coreboot.org/c/coreboot/+/43988/2/src/mainboard/google/voltee... 
PS2, Line 57: const struct lpddr4x_cfg *(void)
> function name is missing : variant_memory_params

Done.