Yilin Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45447 )
Change subject: util/rockchip: Port make_idb.py to python3
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45447/4/util/rockchip/make_idb.py
File util/rockchip/make_idb.py:
https://review.coreboot.org/c/coreboot/+/45447/4/util/rockchip/make_idb.py@1
PS4, Line 1: #!/usr/bin/env python3
Can it be ported in a way, that it’s compatible with Python 2 and 3, so only `python` is used.
Sometimes it's possible, if there is no complicated string issue. But python2 is totally out of support now, is there any reason that we want to support both version ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45447
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04253084ec9b65310c52598b629390051cd2172b
Gerrit-Change-Number: 45447
Gerrit-PatchSet: 4
Gerrit-Owner: Yilin Yang
kerker@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Sep 2020 13:12:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment