[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Support to initialize Memory

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39847 )

Change subject: soc/intel/tigerlake: Support to initialize Memory
......................................................................

Patch Set 15:

(3 comments)

https://review.coreboot.org/c/coreboot/+/39847/13/src/soc/intel/tigerlake/me... 
File src/soc/intel/tigerlake/meminit_tgl.c:

https://review.coreboot.org/c/coreboot/+/39847/13/src/soc/intel/tigerlake/me... 
PS13, Line 297: 	*spd_len = blk->len;
*spd_len = blk->len; seems not needed, you can assign this after you get the blk.

https://review.coreboot.org/c/coreboot/+/39847/13/src/soc/intel/tigerlake/me... 
PS13, Line 300: static void ddr4_get_spd(unsigned int channel, uintptr_t *spd_md_data,
The channel(variable i) is defined as DDR4_CHANNELS, we need try to avoid the hard code for the statement like if(channel == 0). You will miss something after future maintaining.

https://review.coreboot.org/c/coreboot/+/39847/13/src/soc/intel/tigerlake/me... 
PS13, Line 363: 		mem_cfg->MemorySpdDataLen = spd_sodimm_len;
mem_cfg->MemorySpdDataLen=spd_sodimm_blk->len