[coreboot-gerrit] Change in ...coreboot[master]: arch/x86/acpi: Add os.asl

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33652 )

Change subject: arch/x86/acpi: Add os.asl
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/33652/1/src/arch/x86/acpi/os.asl 
File src/arch/x86/acpi/os.asl:

https://review.coreboot.org/#/c/33652/1/src/arch/x86/acpi/os.asl@77 
PS1, Line 77: 		}
missing _OSI Strings for

(OSI String            	Target OS)
Windows 2013       	Windows 8.1
Windows 2015       	Windows 10
Windows 2016       	Windows 10, version 1607
Windows 2017       	Windows 10, version 1703
Windows 2017.2     	Windows 10, version 1709
Windows 2018      	Windows 10, version 1803
Windows 2018.2	  	Windows 10, version 1809

( https://docs.microsoft.com/en-us/windows-hardware/drivers/acpi/winacpi-osi )

https://review.coreboot.org/#/c/33652/1/src/arch/x86/acpi/os.asl@84 
PS1, Line 84: Zero
> Just because I kind of copied the code from another BIOS (UEFI) using RWeverithing, with some modifi […]

if I'm not wrong, "Zero" is also ok