Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34838 )
Change subject: mb/up/squared: Do RAM config based on SKU ID
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34838/11/src/mainboard/up/squared/r...
File src/mainboard/up/squared/romstage.h:
PS11:
is this really needed? I don't see this function being called outside of romstage.c, so I'd rather put the function prototype there or move the function before the function calling it and mark the function as static
https://review.coreboot.org/c/coreboot/+/34838/11/src/mainboard/up/squared/r...
File src/mainboard/up/squared/romstage.c:
https://review.coreboot.org/c/coreboot/+/34838/11/src/mainboard/up/squared/r...
PS11, Line 69: memory_skuid
maybe use an enum for this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34838
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic121652213d5b1f65cff2f3096e919a3cf88db72
Gerrit-Change-Number: 34838
Gerrit-PatchSet: 11
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 14 Sep 2019 10:56:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment