2 comments:
File src/mainboard/up/squared/romstage.h:
is this really needed? I don't see this function being called outside of romstage.c, so I'd rather put the function prototype there or move the function before the function calling it and mark the function as static
File src/mainboard/up/squared/romstage.c:
Patch Set #11, Line 69: memory_skuid
maybe use an enum for this?
To view, visit change 34838. To unsubscribe, or for help writing mail filters, visit settings.