Attention is currently required from: Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/87226?usp=email )
Change subject: util/mediatek: Add check-pi-img.py
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87226/comment/02e507c4_d752dd06?usp... :
PS2, Line 9: Add a script to perform validity check of the PI_IMG firmware.
For ignorants like me: […]
Done.
File util/mediatek/check-pi-img.py:
https://review.coreboot.org/c/coreboot/+/87226/comment/3a2a3a3f_bebf9851?usp... :
PS2, Line 24: {} cookies found
Maybe extend the error message, that exactly two cookies need to be present.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87226?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I27011492c7fab747aa3ee12d514d20a6a52d0a4d
Gerrit-Change-Number: 87226
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Fri, 11 Apr 2025 08:24:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
