Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36045 )
Change subject: mb/g/drallion: Enable privacy screen on Drallion variant ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36045/10/src/mainboard/google/drall... File src/mainboard/google/drallion/Kconfig:
https://review.coreboot.org/c/coreboot/+/36045/10/src/mainboard/google/drall... PS10, Line 5: if BOARD_GOOGLE_DRALLION probably doesn't need the if clause, if the device isn't in devicetree it should get removed by LTO.
https://review.coreboot.org/c/coreboot/+/36045/10/src/mainboard/google/drall... File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36045/10/src/mainboard/google/drall... PS10, Line 229: 0x80010400 add a comment describing the format?