Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34662 )
Change subject: Documentation/binaries: Add AMD FSP documentation ......................................................................
Patch Set 15:
(24 comments)
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... File Documentation/binaries/amd/AMD_FSP_family_17h.md:
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 8: developed\
Oops, will remove.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 9: which is UEFI
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 9: AMD's AGESA V9 (also UEFI).
You mean v9... will do.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 13: in turn
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 13: causes
Dropping the phrase will make this null.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 13: differences
Will figure out exactly how to do it.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 14: , which will
Sure.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 15: "**FSP Differences caused by hardware and AGESA differences**"
I wanted it to stick out, to mark as a sub-title very visibly. […]
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 16: .
Thanks, will fix.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 17: AGESA
I disagree with a position of placing "blame" on AGESA. […]
Ack
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 18: CAR
Add a period to match other bullet items.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 19: to : be placed
will do.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 22: As a consequence of the above, reset
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 31: support
Ok.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 32: As a consequence, there’s no need of FSP-T
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 33: FSP-M is needed (basically reporting memory).
Ok
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 34: AGESA internal dependencies don't conform to FSP specs
I guess now it can be removed.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 35: Currently all code is being landed in FSP-M due to AGESA dependencies. : However it's intended that some code will land in FSP-S in the future.
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 47: TBD
Replace with "will be documented separately for each project using the FSP framework". […]
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 48: : ## Current functionality distribution : : * This is a temporary item, to be updated as work progresses. This will be : removed as work ends. : * All AGESA DXE code made PEI. Most code being interfaced through FSP-M, : though some code already being interfaced through FSP-S. This changes almost : weekly, so no point on describing what is currently where. : * Current problems are related to AGESA and hardware dependencies, such as : memory reporting depends on PCI-e initialization.
Ok.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 69: Picasso
Ok.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 70: doesn't depend on memory reporti
Ok.
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 70: , including devices : we are not yet aware of.
Ok
Done
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd... PS15, Line 72:
Ok.
Done