Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35484 )
Change subject: util/smc: Add and use new tool smcbiosinfo ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35484/7/Documentation/mainboard/sup... File Documentation/mainboard/supermicro/flashing_on_vendorbmc.md:
https://review.coreboot.org/c/coreboot/+/35484/7/Documentation/mainboard/sup... PS7, Line 8: Bytes
bytes
Done
https://review.coreboot.org/c/coreboot/+/35484/7/Documentation/mainboard/sup... PS7, Line 9: Besides the *BoardID* it contains the *firmware version* and *build date*.
Please do not wrap the line.
Done
https://review.coreboot.org/c/coreboot/+/35484/7/Documentation/mainboard/sup... PS7, Line 12: it's not.
Fits on one line?
Done
https://review.coreboot.org/c/coreboot/+/35484/5/src/vendorcode/smc/Makefile... File src/vendorcode/smc/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35484/5/src/vendorcode/smc/Makefile... PS5, Line 11: $(SMCBIOSINFOTOOL): util/smc/smcbiosinfo/smcbiosinfo.c $(build_h)
put that stuff in util/**/Makefile. […]
Done
https://review.coreboot.org/c/coreboot/+/35484/5/src/vendorcode/smc/Makefile... PS5, Line 11: $(build_h)
consider passing the data into the tool through command line arguments
doesn't work. Those information are only present in build.h