Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43133 )
Change subject: baytrail RFC: native replacement for refcode.elf ......................................................................
Patch Set 5:
(11 comments)
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/incl... File src/soc/intel/baytrail/include/soc/iosf.h:
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/incl... PS5, Line 97: align with tabs?
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/incl... PS5, Line 114: 0xa3 0xa6
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/incl... File src/soc/intel/baytrail/include/soc/modphy_table.h:
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/incl... PS5, Line 17: reva a0
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/incl... PS5, Line 18: revb b0
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/refc... File src/soc/intel/baytrail/refcode_native.c:
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/refc... PS5, Line 47: #define IOSF_READ(op_read, port) \
Macros with complex values should be enclosed in parentheses
Please fix this, it can bite you
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/refc... PS5, Line 84: 1 This will make more sense if you use shifts:
(1 << 0)
Or, the BIT(x) macro:
BIT(0)
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/refc... PS5, Line 85: 4 (1 << 2)
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/refc... PS5, Line 86: 0xFFFFFFFD ~(1 << 1)
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/refc... PS5, Line 87: 0xFFFFFFF8 ~(1 << 3)
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/refc... PS5, Line 114: iosf_bunit_write(BUNIT_BALIMIT0, (tmp & 0xC0D0D0D0) | 0x1F2F2F2F); How about adding and-or functions?
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/refc... PS5, Line 137: Replacment Replacement