11 comments:
File src/soc/intel/baytrail/include/soc/iosf.h:
align with tabs?
0xa6
File src/soc/intel/baytrail/include/soc/modphy_table.h:
a0
b0
File src/soc/intel/baytrail/refcode_native.c:
Patch Set #5, Line 47: #define IOSF_READ(op_read, port) \
Macros with complex values should be enclosed in parentheses
Please fix this, it can bite you
This will make more sense if you use shifts:
(1 << 0)
Or, the BIT(x) macro:
BIT(0)
(1 << 2)
Patch Set #5, Line 86: 0xFFFFFFFD
~(1 << 1)
Patch Set #5, Line 87: 0xFFFFFFF8
~(1 << 3)
Patch Set #5, Line 114: iosf_bunit_write(BUNIT_BALIMIT0, (tmp & 0xC0D0D0D0) | 0x1F2F2F2F);
How about adding and-or functions?
Patch Set #5, Line 137: Replacment
Replacement
To view, visit change 43133. To unsubscribe, or for help writing mail filters, visit settings.