[coreboot-gerrit] Change in coreboot[master]: soc/intel: Add Intel Xeon Scalable Processor support

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )

Change subject: soc/intel: Add Intel Xeon Scalable Processor support
......................................................................

Patch Set 32:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38548/32/src/soc/intel/xeon_sp/unco... 
File src/soc/intel/xeon_sp/uncore.c:

https://review.coreboot.org/c/coreboot/+/38548/32/src/soc/intel/xeon_sp/unco... 
PS32, Line 18: include <cbmem.h>
             : #include <console/console.h>
             : #include <arch/acpi.h>
             : #include <arch/io.h>
             : #include <stdint.h>
             : #include <delay.h>
             : #include <device/device.h>
             : #include <device/pci.h>
             : #include <device/pci_ids.h>
             : #include <stdlib.h>
             : #include <string.h>
             : #include <romstage_handoff.h>
             : #include <timer.h>
             : #include <cpu/x86/lapic.h>
             : 
             : #include <fsp/util.h>
             : #include <fsp/memory_init.h>
             : 
             : #include <soc/soc_util.h>
             : #include <soc/iomap.h>
             : #include <soc/pci_devs.h>
             : #include <soc/ramstage.h>
             : #include <soc/acpi.h>
please include Only what you use.

(same for the other files)