Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46687 )
Change subject: mb/google/asurada: Implement enable_requlator and regulator_is_enabled ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46687/4/src/mainboard/google/asurad... File src/mainboard/google/asurada/regulator.c:
https://review.coreboot.org/c/coreboot/+/46687/4/src/mainboard/google/asurad... PS4, Line 104: regulator
id? It's fine if you wan to print regulator instead of id.
Ack. It is easier to know what input value causes the invalid ID.
https://review.coreboot.org/c/coreboot/+/46687/4/src/mainboard/google/asurad... PS4, Line 118: regulator
id?
Ack
https://review.coreboot.org/c/coreboot/+/46687/4/src/mainboard/google/asurad... PS4, Line 122: = 0
No need for initialization.
Ack
https://review.coreboot.org/c/coreboot/+/46687/4/src/mainboard/google/asurad... PS4, Line 126: regulator
id?
Ack