Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41155 )
Change subject: soc/intel/common/block/systemagent: Use TOUUD as base for MMIO above 4G ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41155/2/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/41155/2/src/soc/intel/common/block/... PS2, Line 118: if (!get_enable_above_4GB_mmio())
After making sure we have right base and limit like below CL, we don't see such issue as mentioned above.
If there was an error in reporting and now it is fixed, why not always advertise the correct MMIO window available above 4G? Why is it made conditional?
I was making this conditional to remain parity with FSP/RC implementation.
FSP/RC is oriented around Windows and legacy requirements. It's not necessarily applicable to things outside of that. Could you please look into always advertising the correct decode window above 4GiB? I think that's the simplest and most straight forward way to go. I honestly can't envision any situation where advertising that window would cause things to misbehave unless it's an OS limitation.