Attention is currently required from: Benjamin Doron, Martin L Roth, Patrick Rudolph, Simon Glass.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78913?usp=email )
Change subject: payloads: Add uefistub payload ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
For 64-bit SMBIOS (I suppose the SMBIOS3 header) there is a patch[1] but it needs a bit of work, or perhaps that has already been done. In any case, I can help, or Heinrich / others on the ML.
For ACPI, can you share your working code? The ACPI code is now fairly generic so enabling it on ARM should not be difficult. Of course any new thing has challenges.
I will see that I sort out and clean up my patches, but its gonna take a while. My TODO list is a bit full currently.
We have enough forking going on in private projects. I would really like to see more collaboration between coreboot and U-Boot.
I am all for enhancing the coreboot support in u-boot but that doesn't mean I will decide against this payload. There is no harm in alternative (open source) solutions. It is not tied/integrated into coreboot. No one needs to use it if they don't want to.
I did do some fiddling on U-Boot as a library a while back. It is a big effort though...so using the existing payload seems a lot easier.
I didn't mean u-boot to be library. I meant only the UEFI implementation part to be a library or separate executable. Similar to EDK2Payload or efistub in Linux (just the other way around). Or like this uefistub. It does one specific task and that is providing a UEFI interface to payload. It is very small, fast and simple (as simple as UEFI can be...).
File payloads/uefistub/src/efi_boot_services.c:
https://review.coreboot.org/c/coreboot/+/78913/comment/94bc6353_8df6a007 : PS4, Line 134: .get_next_monotonic_count = (void *)efi_unimplemented, must return EFI_DEVICE_ERROR instead of EFI_UNSUPPORTED https://github.com/ARM-software/ebbr/blob/main/source/chapter2-uefi.rst#mono...
File payloads/uefistub/src/efi_table.c:
https://review.coreboot.org/c/coreboot/+/78913/comment/20b06d4e_5b52069f : PS4, Line 25: .reset = (void *)efi_unimplemented, must return EFI_DEVICE_ERROR instead of EFI_UNSUPPORTED https://uefi.org/specs/UEFI/2.10/12_Protocols_Console_Support.html#efi-simpl...