Attention is currently required from: Tzung-Bi Shih, Yu-Ping Wu. Tzung-Bi Shih has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49135 )
Change subject: mb/google/asurada: Support audio ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49135/comment/d103f71c_020d2395 PS1, Line 7: google/asurada: support beep
mb/google/asurada: Support beep sound
Done. I changed it a bit.
https://review.coreboot.org/c/coreboot/+/49135/comment/d4bb7026_8b96288f PS1, Line 10:
BUG=b:176856418
NACK, this is coreboot upstream, IIUC, BUG= shouldn't require.
File src/mainboard/google/asurada/mainboard.c:
https://review.coreboot.org/c/coreboot/+/49135/comment/b88e083a_6811e87e PS1, Line 198: *
Need a space
Done