Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40377 )
Change subject: coreboot-id: Add coreboot id based on FMAP entries
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40377/2/src/mainboard/lenovo/t530/v...
File src/mainboard/lenovo/t530/vboot-rwab.fmd:
https://review.coreboot.org/c/coreboot/+/40377/2/src/mainboard/lenovo/t530/v...
PS2, Line 28: COREBOOT_ID 0x40
some use 0x40, other 0x100 as size for COREBOOT_ID. […]
0x40 is all that is needed. On most platforms, there was padding present where I could borrow from. In other cases, I borrowed from a huge FMAP region, but to keep size of previous and next regions aligned similarly, I borrowed a little extra. I can rework to make all 0x40.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40377
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1aaf36bec00b4cffc46a3640a5a0d1e4bb8067
Gerrit-Change-Number: 40377
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 Apr 2020 19:34:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment