Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31767 )
Change subject: soc/qualcomm/qcs405: Support for new SoC
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31767/1/src/soc/qualcomm/qcs405/Kconfig
File src/soc/qualcomm/qcs405/Kconfig:
https://review.coreboot.org/#/c/31767/1/src/soc/qualcomm/qcs405/Kconfig@19
PS1, Line 19: VBOOT_OPROM_MATTERS
That is normally used for devices with an "option rom" for graphics initialization. qcs405 sounds very much not like such a device. What is this for here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31767
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e1078b23921f02e505b374ad515ab92260a6dda
Gerrit-Change-Number: 31767
Gerrit-PatchSet: 1
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-Comment-Date: Wed, 06 Mar 2019 11:07:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment