Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35400 )
Change subject: mb/emulation/qemu: Add VBOOT support ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35400/4/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-i440fx/vboot-rwa-16M.fmd:
https://review.coreboot.org/c/coreboot/+/35400/4/src/mainboard/emulation/qem... PS4, Line 9: SMMSTORE(PRESERVE) 0x40000
It has a RO boot medium atm and smmstore is not hooked up so I'd remove this.
Done
https://review.coreboot.org/c/coreboot/+/35400/4/src/mainboard/emulation/qem... PS4, Line 11: 0x7ff000
remove this to have it aligned at the bootom
Done
https://review.coreboot.org/c/coreboot/+/35400/4/src/mainboard/emulation/qem... PS4, Line 17: @0x20000 0x7df000
remove this to have it aligned at the bottom.
Done
https://review.coreboot.org/c/coreboot/+/35400/4/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-q35/Kconfig:
https://review.coreboot.org/c/coreboot/+/35400/4/src/mainboard/emulation/qem... PS4, Line 11: s
select BOARD_ROMSIZE_KB_2048 if !VBOOT […]
Done