David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42731 )
Change subject: mb/google/volteer/var/voxel: Update gpio settings and overridetree.cb
......................................................................
Patch Set 4:
(2 comments)
Thanks.
https://review.coreboot.org/c/coreboot/+/42731/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/voxel/gpio.c:
https://review.coreboot.org/c/coreboot/+/42731/3/src/mainboard/google/voltee...
PS3, Line 32: VRALERT_L
just curious - do you want to change the comment […]
Done
https://review.coreboot.org/c/coreboot/+/42731/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/voxel/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42731/3/src/mainboard/google/voltee...
PS3, Line 117: # SBU & HSL follow CC
change to TYPEC_ORIENTATION_NORMAL (identical to port C1) since […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42731
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49c1923e63d87f11de362fd893905ac2f1137bba
Gerrit-Change-Number: 42731
Gerrit-PatchSet: 4
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 02 Jul 2020 11:29:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment