Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47152 )
Change subject: mb/google/zork: Create Shuboz variant
......................................................................
Patch Set 3: Code-Review+2
looks good to me.
FYI: In upstream coreboot review it's rather uncommon to +1 own patches; usually when a patch is uploaded for review and it's not marked as work in progress, not for merge or something like that, people will assume that it's working and ready to be reviewed. You probably can't +2 patches yet, but +2ing own patches is something that people shouldn't do as it basically would bypass the review. Having someone else do the review really helps spotting bugs.
No need to worry about this here, since it's only a +1, but it would be good to keep this in mind for future patches
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47152
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f62625f8cbde1c9adf8ab335edeb9e811e32679
Gerrit-Change-Number: 47152
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Randy I-Fan Wang
ifanw@google.com
Gerrit-Comment-Date: Mon, 09 Nov 2020 10:21:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment