13 Oct
2019
13 Oct
'19
2:40 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35990 )
Change subject: cpu/intel/car: Correctly cache the bootblock with C_ENVIRONMENT_BOOTBLOCK ......................................................................
Patch Set 3:
(1 comment)
What difference does it make? Do we expect trouble if we keep the old cache setup for C-env bootblock?
https://review.coreboot.org/c/coreboot/+/35990/3/src/cpu/intel/car/core2/cac... File src/cpu/intel/car/core2/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/35990/3/src/cpu/intel/car/core2/cac... PS3, Line 28: #endif Move to `mtrr.h`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/35990
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8104ca9c51e4d2eccdb277e4c2111d2da662f3e
Gerrit-Change-Number: 35990
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Sun, 13 Oct 2019 12:40:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment