[coreboot-gerrit] Change in ...coreboot[master]: libpayload/i8042/keyboard: Fix return value check for keyboard_cmd

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33185 )

Change subject: libpayload/i8042/keyboard: Fix return value check for keyboard_cmd
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/33185/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33185/3//COMMIT_MSG@21 
PS3, Line 21: anymore.
> The keyboard was non-functional on the platform I was using. […]

We were observing that the keyboard did not work with this change.

https://review.coreboot.org/#/c/33185/3/payloads/libpayload/drivers/i8042/ke... 
File payloads/libpayload/drivers/i8042/keyboard.c:

https://review.coreboot.org/#/c/33185/3/payloads/libpayload/drivers/i8042/ke... 
PS3, Line 322: 	if (!ret) {
> Should it also be possible to ignore the init failure? […]

I initially thought of doing that, but looking at the places where this was added, it seemed to be specific to scanning i.e. setting of scancode or enable scanning. I can add that in a follow-up commit if it seems to be the right thing to do here. +Duncan.