Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34137 )
Change subject: soc/intel/common: Add function to check if PCI device is a LPSS controller ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34137/4/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/lpss.h:
https://review.coreboot.org/c/coreboot/+/34137/4/src/soc/intel/common/block/... PS4, Line 35: soc
nit: All the soc specific functions have the format with soc_*. Prefer to maintain that format. […]
Done
https://review.coreboot.org/c/coreboot/+/34137/4/src/soc/intel/common/block/... File src/soc/intel/common/block/lpss/lpss.c:
https://review.coreboot.org/c/coreboot/+/34137/4/src/soc/intel/common/block/... PS4, Line 80: is_dev_lpss
r u planning to call this function multiple time ?
With the irq implementation yes, wanted to avoid SOC callbacks everytime.
https://review.coreboot.org/c/coreboot/+/34137/4/src/soc/intel/common/block/... PS4, Line 83: static const int *lpss_devices;
Please leave a blank line between declaration block and function body.
Done
https://review.coreboot.org/c/coreboot/+/34137/4/src/soc/intel/common/block/... PS4, Line 87: dev->path.pci.devfn
It is also better to ensure that the device path is a PCI type in addition to checking the devfn.
certainly. Included the check now. Thanks.