4 comments:
File src/soc/intel/common/block/include/intelblocks/lpss.h:
nit: All the soc specific functions have the format with soc_*. Prefer to maintain that format. […]
Done
File src/soc/intel/common/block/lpss/lpss.c:
Patch Set #4, Line 80: is_dev_lpss
r u planning to call this function multiple time ?
With the irq implementation yes, wanted to avoid SOC callbacks everytime.
Patch Set #4, Line 83: static const int *lpss_devices;
Please leave a blank line between declaration block and function body.
Done
Patch Set #4, Line 87: dev->path.pci.devfn
It is also better to ensure that the device path is a PCI type in addition to checking the devfn.
certainly. Included the check now. Thanks.
To view, visit change 34137. To unsubscribe, or for help writing mail filters, visit settings.