Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48143 )
Change subject: mb/kontron/mal10: Use mainboard_ops driver for GPIO configuration
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48143/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48143/6//COMMIT_MSG@11
PS6, Line 11: the init phase from the mainboard_ops driver for configuring the GPIOs.
Well, if you have access to schematics, I'd rather check if the gpios are correct. […]
Well, initial inteltool GPIO dump is taken from vendor firmware, so coreboot code ordering didn't matter at that point.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia01091938ac113cb5cf95f046609a1ebf3620806
Gerrit-Change-Number: 48143
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Jan 2021 17:12:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment