Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 27:
(2 comments)
Patch Set 27:
Patch Set 27:
Patch Set 26:
I admit I did not read through all the commit messages for argumentation why you want the directory renamed.
That's the problem here ;-) The discussion is going on since weeks.
Use of variants/ is welcome for sure for similar board ports. While the base directory name can be somewhat arbitrary, including the socket type 'lga1151-series' there is kind of introducing a completely new naming scheme; I am not so convinced that we want that. Sometimes we have just kept the name of the first ported board as the base directory name, IMHO that would have been just fine here.
I really do NOT want to discuss this another time. We already discussed this a) 4 times on gerrit and b) multiple times in IRC. We agreed on 'lga1151-series'.
Sometimes we have just kept the name of the first ported board
This would be very bad because there are about 20 boards we can support in this series.
Please summarize the discussion in the commit message.
Will do
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG@11 PS27, Line 11: see CR 35427
Need needed. If it is, please use the Change-Id and the commit message summary.
What is needed?
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG@9 PS27, Line 9: Most of the X11 boards with socket LGA1151 are basically the same : boards with just some minor differences. : To be able to add more x11 boards easily like x11ssm (see CR 35427) : this restructures the x11ssh tree.
Please do not break the line after a sentence. […]
huh? This is one sentence, newline because of line limit