Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41658 )
Change subject: nb/intel/haswell: Add Crystal Well PCI IDs
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41658/1/src/northbridge/intel/haswe...
File src/northbridge/intel/haswell/northbridge.c:
https://review.coreboot.org/c/coreboot/+/41658/1/src/northbridge/intel/haswe...
PS1, Line 469: 0x0d00, 0x0d04, /* Crystal Well */
Can we add each on a separate line for consistency, please?
0x0d00 is Desktop, and 0x0d04 is Mobile
Also add 0x0d08 as Crystalwell Server, by extrapolation
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfe55323fd06187148c788ebfa7b679b6944e4f3
Gerrit-Change-Number: 41658
Gerrit-PatchSet: 1
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 22 May 2020 16:36:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment