Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44905 )
Change subject: mb/google/puff: Convert ASL file to new DPTF dt impl ......................................................................
Patch Set 12:
(11 comments)
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/duffy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... PS12, Line 274: .thresholds={TEMP_PCT(90, 85), : TEMP_PCT(85, 75), : TEMP_PCT(75, 65), : TEMP_PCT(65, 55), : TEMP_PCT(55, 45),}}"
This is slightly different than dptf.asl, should be: […]
Fixed. Thank you.
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... PS12, Line 295: # 10-15W PL1 in 200mW increments, avg over 28-32s interval : # PL2 is fixed at 64W, avg over 28-32s interval
These comments are not accurate; PL1 is fixed at 15W here, and PL2 can range from 25-64W
Done
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/faffy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... PS12, Line 288: is fixed at 64W
ranges from 25 to 51W
Done
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/kaisa/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... PS12, Line 295: 10-15W PL1
PL1 fixed at 15W
Done
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... PS12, Line 296: PL2 is fixed at 64W
PL2 ranges from 25 to 64W
Done
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/noibat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... PS12, Line 221: 10-15W PL1
PL1 fixed at 15W
Done
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... PS12, Line 222: PL2 is fixed at 64W
PL2 ranges from 25 to 64W
Done
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/puff/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... PS12, Line 233: 10-15W PL1 in 200mW increments
PL1 fixed at 15W
Done
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... PS12, Line 234: PL2 is fixed at 64W
PL2 ranges from 25 to 64W
Done
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/wyvern/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... PS12, Line 228: 10-15W PL1 in 200mW increments
PL1 fixed at 15W
Done
https://review.coreboot.org/c/coreboot/+/44905/12/src/mainboard/google/hatch... PS12, Line 229: PL2 is fixed at 64W
PL2 ranges from 25 to 64W
Done