Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31373 )
Change subject: vendorcode/amd/pi: Add merlinfalcon AGESA support ......................................................................
Patch Set 2:
(2 comments)
Patch Set 2:
(2 comments)
This should be split and the commit message redone. FWIW, could probably put the Kconfig change in https://review.coreboot.org/#/c/coreboot/+/31372/
I should not place vendor code Kconfig with soc/amd/stoneyridge changes. This change is about providing AGESA to merlinfalcon, thus Kconfig and gcccar.inc changes belong here.
https://review.coreboot.org/#/c/31373/2/src/vendorcode/amd/pi/00670F00/binar... File src/vendorcode/amd/pi/00670F00/binaryPI/gcccar.inc:
https://review.coreboot.org/#/c/31373/2/src/vendorcode/amd/pi/00670F00/binar... PS2, Line 1160: # This one instruction is for merlinfalcon, harmless for stoneyridge.
I wouldn't bother with this. You could change the comment below to say it's for all cores. […]
Ok, I'll use his comment.
https://review.coreboot.org/#/c/31373/2/src/vendorcode/amd/pi/Kconfig File src/vendorcode/amd/pi/Kconfig:
https://review.coreboot.org/#/c/31373/2/src/vendorcode/amd/pi/Kconfig@46 PS2, Line 46: "3rdparty/blobs/pi/amd/00660F01/FP4/AGESA.bin"
Trying to think ahead... […]
As you mentioned, this forces the break into multiple commits. 1 commit to the blob, committing new blob to main coreboot (already needed due to video), and finally the kconfig plus gcccar.inc.