Patch Set 2:

(2 comments)

This should be split and the commit message redone. FWIW, could probably put the Kconfig change in https://review.coreboot.org/#/c/coreboot/+/31372/

I should not place vendor code Kconfig with soc/amd/stoneyridge changes. This change is about providing AGESA to merlinfalcon, thus Kconfig and gcccar.inc changes belong here.

View Change

2 comments:

• File src/vendorcode/amd/pi/00670F00/binaryPI/gcccar.inc:

  • Patch Set #2, Line 1160: # This one instruction is for merlinfalcon, harmless for stoneyridge.

    I wouldn't bother with this. You could change the comment below to say it's for all cores. […]

    Ok, I'll use his comment.

• File src/vendorcode/amd/pi/Kconfig:

  • Patch Set #2, Line 46: "3rdparty/blobs/pi/amd/00660F01/FP4/AGESA.bin"

    Trying to think ahead... […]

    As you mentioned, this forces the break into multiple commits. 1 commit to the blob, committing new blob to main coreboot (already needed due to video), and finally the kconfig plus gcccar.inc.

To view, visit change 31373. To unsubscribe, or for help writing mail filters, visit settings.