Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/28769 )
Change subject: amd/stoneyridge: Add ASL for D-states on AOAC devices ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/28769/1/src/soc/amd/stoneyridge/acpi/sb_pci0... File src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl:
https://review.coreboot.org/#/c/28769/1/src/soc/amd/stoneyridge/acpi/sb_pci0... PS1, Line 444: Case(Package() {5, 15, 24}) { : Store(One, PG1A) : } : Case(Package() {6, 7, 8, 11, 12, 18}) { : Store(One, PG2_) : } : What about Arg0 = 23?
https://review.coreboot.org/#/c/28769/1/src/soc/amd/stoneyridge/acpi/sb_pci0... PS1, Line 501: /* todo Case(15) { STD0()} */ /* SATA */ : /* todo Case(18) { U2D0()} */ /* EHCI */ : /* todo Case(23) { U3D0()} */ /* XHCI */ : /* todo Case(24) { SDD0()} */ /* SD */ : shouldn't there be a default statement?
https://review.coreboot.org/#/c/28769/1/src/soc/amd/stoneyridge/acpi/sb_pci0... PS1, Line 557: * todo Case(15) { STD3()} */ /* SATA * default?