Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41785 )
Change subject: cpu/x86/mtrr.h: Get rid of commonlib/helpers.h dependency
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41785/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41785/1//COMMIT_MSG@11
PS1, Line 11: definition.
Where is the ALIGN() macro being used in the CACHE_ROM_* macros? Sorry, I poked around and couldn't see it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41785
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bf20733418ca4135f364a3f6489e74d45e4f466
Gerrit-Change-Number: 41785
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Wed, 27 May 2020 16:18:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment