Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39340 )
Change subject: chromeos: remove get_write_protect_state function ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39340/3/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/39340/3/src/drivers/mrc_cache/mrc_c... PS3, Line 438: /* Read Write Protect GPIO if available */ : wp_gpio = get_write_protect_state();
Yeah this GPIO check was to make it easy to do a full RO update once booted without WP enabled. […]
Hmmm... okay, you convinced me, this is not as simple as I thought.
In practice, x86 devices still need this GPIO defined in coreboot anyway, because it has to be reported through ACPI. So getting rid of it is not worth that much there and it's probably easiest if we just leave in get_write_protect_state() for x86 only. (Arm devices, even if they used mrc_cache, don't have PRRs so they wouldn't get to here.)