Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38648 )
Change subject: util/cbfstool: extend includes in commonlib
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Please post your error messages for both cases so we can try to figure out why it doesn't work.
HOSTCC cbfstool/lz4_wrapper.o
/usr/home/idwer/github.com/coreboot/coreboot/src/commonlib/bsd/lz4_wrapper.c:5:10: fatal error: 'endian.h' file not found
#include <endian.h>
^~~~~~~~~~
Would it be a cursed idea to wrap endian header inclusions in something like `os_endian.h` ?
os_endian.h could confuse dyslexics. Let's go with sysincludes.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38648
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd81c2a96c608589ce2ec8f4b883fd4e584776b1
Gerrit-Change-Number: 38648
Gerrit-PatchSet: 1
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Feb 2020 14:44:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment