Attention is currently required from: Bora Guvendik, Nico Huber, Wonkyu Kim, Jérémy Compostella, Nicholas Chin.
Selma Bensaid has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67118 )
Change subject: libpayload/Makefile.inc: Initialize vboot depending on UPDATED_SUBMODULES
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
@Nicholas, thanks for all the details. I don't think my last patch set change the behavior of a payload standalone build.
However this patch is needed for teams who do not want to use the submodule version of vboot or any other submodule. For example in my side I build coreboot UPDATED_SUBMODULES=1 make, by setting UPDATED_SUBMODULES=1 I want to ensure that I'm building with the repos as I installed them (I'm using a manifest).
File payloads/libpayload/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/67118/comment/2d4eeb91_a1f5c7d4
PS2, Line 91: ifneq ($(UPDATED_SUBMODULES),1)
Apparently one purpose of UPDATED_SUBMODULES in coreboot's top level Makefile. […]
Hi Nicholas, my patch set 2 should adress
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67118
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d58b863cf709930900c7e691e52cac71f88a349
Gerrit-Change-Number: 67118
Gerrit-PatchSet: 3
Gerrit-Owner: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Fri, 02 Sep 2022 21:54:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Selma Bensaid
selma.bensaid@intel.com
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-MessageType: comment