[coreboot-gerrit] Change in coreboot[master]: ec/google/chromeec: Append connector device to *-switch properties

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42045 )

Change subject: ec/google/chromeec: Append connector device to *-switch properties
......................................................................

Patch Set 2:
> Patch Set 2: Code-Review+2
> > Patch Set 2:
> > > Patch Set 2:
> > >
> > > I run into an issue trying to verify this patch.  
> > > To verify, I
> > > cherry-pick, flash and boot volteer
> > > cat /sys/firmware/acpi/tables/DDST > /tmp/ssdt.dml"
> > > scp DUT:/tmp/ssdt.dml back to my host linux box
> > > iasl -d ./ssdt.dml > ./ssdt.txt
> > >
> > > The contents of "./ssdt.txt" is the three lines : 
> > >   Intel ACPI Component Architecture
> > >   ASL+ Optimizing Compiler/Disassembler version 20180810
> > >   Copyright (c) 2000 - 2018 Intel Corporation
> > >
> > > The following is the stderr output of the "iasl -d ./ssdt.dml > ssdt.txt" :
> > >
> > > Found 2 external control methods, reparsing with new information
> > > Pass 1 parse of [SSDT]
> > > Pass 2 parse of [SSDT]
> > > Parsing Deferred Opcodes (Methods/Buffers/Packages/Regions)
> > >
> > > Parsing completed
> > > Disassembly completed
> > > ASL Output:    ./SSDT.dsl - 47137 bytes
> > >
> > > iASL Warning: There were 2 external control methods found during
> > >  disassembly, but only 0 were resolved (2 unresolved). Additional
> > >  ACPI tables may be required to properly disassemble the code. This
> > >  resulting disassembler output file may not compile because the
> > >  disassembler did not know how many arguments to assign to the
> > >  unresolved methods. Note: SSDTs can be dynamically loaded at
> > >  runtime and may or may not be available via the host OS.
> > >
> > > To specify the tables needed to resolve external control method
> > >  references, the -e option can be used to specify the filenames.
> > >  Example iASL invocations:
> > >      iasl -e ssdt1.aml ssdt2.aml ssdt3.aml -d dsdt.aml
> > >      iasl -e dsdt.aml ssdt2.aml -d ssdt1.aml
> > >      iasl -e ssdt*.aml -d dsdt.aml
> > >
> > > In addition, the -fe option can be used to specify a file containing
> > >  control method external declarations with the associated method
> > >  argument counts. Each line of the file must be of the form:
> > >      External (<method pathname>, MethodObj, <argument count>)
> > >  Invocation:
> > >      iasl -fe refs.txt -d dsdt.aml
> >
> > Can you add the output from the resulting .dsl file (the top part with the External declarations)
> >
> > There are some dependencies that iasl can't resolve without the DSDT because the SSDT code generation is not explicitly adding External() references to method objects used.
> >
> > If you use both the DSDT and SSDT it should be able to resolve these types of references:
> >
> > iasl -d /tmp/DSDT /tmp/SSDT
>
> Thanks, Duncan.  Using both /tmp/DSDT and /tmp/SSDT, I still get the same error, but do see that the values in the resulting ssdt.dsl file do point to the correct locations.

You shouldn't get any unresolved externals with both, or we have an issue with our AML:
try this:
cd /mnt/stateful_partition
cat /sys/firmware/acpi/tables/SSDT > ssdt.dml
cat /sys/firmware/acpi/tables/DSDT > dsdt.dml
iasl -d dsdt.dml
iasl -e dsdt.dml -d ssdt.dsl

I synced today and with this patch I don't have any unresolved externals. If you still do, can you post it somewhere?