[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/apollolake/romstage: Increase size of postcar stack

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33775 )

Change subject: soc/intel/apollolake/romstage: Increase size of postcar stack
......................................................................

Patch Set 1:
> Patch Set 1:
>
> I would increase all platforms currently use 1KiB to 4KiB, as suggested by Patrick.
>
> src/soc/intel/apollolake/romstage.c			-> postcar_frame_init(&pcf, 1*KiB)
> src/soc/intel/icelake/romstage/romstage.c		-> postcar_frame_init(&pcf, 1*KiB)
> src/soc/intel/cannonlake/romstage/romstage.c		-> postcar_frame_init(&pcf, 1*KiB)
> src/soc/intel/quark/romstage/fsp2_0.c			-> postcar_frame_init(&pcf, 1*KiB)
> src/soc/intel/denverton_ns/romstage.c			-> postcar_frame_init(&pcf, 1*KiB)
> src/soc/amd/stoneyridge/romstage.c			-> postcar_frame_init(&pcf, 1*KiB)
>
> For this I would use the Define ‘ROMSTAGE_COMMON_RAM_STACK_SIZE’, declared in src/include/memlayout.h. This could then be used as the default setting for the postcar stack size.

Sound good to me.
Please add a comment as well to make sure that it won't be accidentally decreased again.