You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31564 )
Change subject: libpayload: cbfs: Check decompressed size when loading files ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/31564/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31564/1//COMMIT_MSG@7 PS1, Line 7: libpayload: cbfs: Check decompressed size when loading files.
Also, please remove the dot at the end of the commit message summary.
Done
https://review.coreboot.org/#/c/31564/1//COMMIT_MSG@15 PS1, Line 15: TEST=boot into kernel on kukui
But that worked before, didn’t it? Or do you have a test case, where there is a compressor/decompres […]
This CL doesn't aim to fix anything. Booting into kernel only to check that this CL doesn't screw up something. Luckily, I don't see any compressor/decompressor bug so far.
https://review.coreboot.org/#/c/31564/1/payloads/libpayload/libcbfs/cbfs_cor... File payloads/libpayload/libcbfs/cbfs_core.c:
https://review.coreboot.org/#/c/31564/1/payloads/libpayload/libcbfs/cbfs_cor... PS1, Line 259: cbfs_decompress
We should probably just change cbfs_decompress to use ulzman() and ulz4n() instead? (Would need to a […]
I've created a separate CL for this: https://review.coreboot.org/c/coreboot/+/31606
https://review.coreboot.org/#/c/31564/1/payloads/libpayload/libcbfs/cbfs_cor... PS1, Line 259: if (ret != NULL && cbfs_decompress(algo, data, ret, *size) != *size) {
I agree an error message would be nice, although one should probably be enough (e.g. […]
error message added.