Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35516 )
Change subject: device/pci: Ensure full 16-bit VGA port i/o decoding
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35516/1/src/include/device/pci_def....
File src/include/device/pci_def.h:
https://review.coreboot.org/c/coreboot/+/35516/1/src/include/device/pci_def....
PS1, Line 174: #define PCI_CB_BRIDGE_CTL_VGA 0x08
cardbus matches, see spec
well, "matches" means we can assume the bit to be reserved for now... (not all registers are the same)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35516
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7a07f069dd54331df79f605c6bcda37882a602d
Gerrit-Change-Number: 35516
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 21 Sep 2019 22:08:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment